-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
298 fix build of version 0.9.5 #299
Conversation
Some additional info: sample tests: hasher1.write(&(0..10).collect::<Vec<u8>>());
hasher2.write(&(245..255).collect::<Vec<u8>>());
hasher3.write(&(63..73).collect::<Vec<u8>>());
hasher4.write(&(101..111).collect::<Vec<u8>>()); Output without flags (different results for aHash v0.8.6 due to different keys):
Output with
Output with
Conclusion: aHash results dependent on |
Please, fix a warning in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #298
Some additional info:
ahash
crate:Copied version of aHash: 0.7.4(with added one typo fix as discussed inhere)
About this test with hash matches:
cargo test
without additional flags passes the testRUSTFLAGS="-C target-feature=+aes,+ssse3" cargo test --target=x86_64-unknown-linux-musl
fails the test (hashes don't match)ahash
and with imported one from github using Cargo github import (faulty test or expected behaviour?)