Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dataframe): parse_csv determines dtypes per column #140

Merged
merged 1 commit into from
Oct 19, 2021
Merged

fix(dataframe): parse_csv determines dtypes per column #140

merged 1 commit into from
Oct 19, 2021

Conversation

dustmop
Copy link
Contributor

@dustmop dustmop commented Oct 18, 2021

No description provided.

@dustmop dustmop requested a review from b5 October 18, 2021 21:44
@dustmop dustmop self-assigned this Oct 18, 2021
@dustmop dustmop mentioned this pull request Oct 19, 2021
Merged
@dustmop
Copy link
Contributor Author

dustmop commented Oct 19, 2021

The real fix here is parsePush in dataframe/typed_slice_builder.go. Everything else is just support for the test for this change.

b5
b5 approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@b5 b5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. nice to see some ergonomic fixes to the test suite as well

@dustmop dustmop merged commit e814c8f into master Oct 19, 2021
@dustmop dustmop deleted the parse-csv-dtypes branch October 19, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b5 b5 b5 approved these changes

Assignees

@dustmop dustmop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dustmop @b5