qt-qml: Always restart qmlls when a new version is installed #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we install a new version of qmlls without stopping the currently running instance, the old version remains active and cannot be replaced. To fix this, qmlls should always be stopped before installing a new version. The root cause of [VSCODEEXT-244](https://bugreports.qt.io/browse/VSCODEEXT-244) is that [commit 884feba](qt-labs@884feba) removed waiting for `qt-cpp` activation and notifying other extensions. This caused qmlls to start immediately when VS Code starts while the popup for updating qmlls is still open. Before that change, when a new qmlls version was published, a popup was shown to the user and qmlls was not started until the user made a choice. After the change, qmlls starts immediately, which causes the old version to keep running and block the update. This commit fixes the issue by always stopping qmlls before installing a new version and restarting it before the user makes a choice. * Improve log messages Fixes: [VSCODEEXT-242](https://bugreports.qt.io/browse/VSCODEEXT-242) Fixes: [VSCODEEXT-244](https://bugreports.qt.io/browse/VSCODEEXT-244)
OrkunTokdemir
force-pushed
the
orkun_qmlls_01_10_2025
branch
from
28ff560 to
2a3e342
Compare
benchoq
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we install a new version of qmlls without stopping the currently running instance, the old version remains active and cannot be replaced. To fix this, qmlls should always be stopped before installing a new version.
The root cause of VSCODEEXT-244 is that commit 884feba removed waiting for
qt-cppactivation and notifying other extensions. This caused qmlls to start immediately when VS Code starts while the popup for updating qmlls is still open.Before that change, when a new qmlls version was published, a popup was shown to the user and qmlls was not started until the user made a choice.
After the change, qmlls starts immediately, which causes the old version to keep running and block the update.
This commit fixes the issue by always stopping qmlls before installing a new version and restarting it before the user makes a choice.
Fixes: VSCODEEXT-242
Fixes: VSCODEEXT-244