Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fn:iterate-while → fn:while-do, fn:do-until #946

Closed
ChristianGruen opened this issue Jan 12, 2024 · 0 comments
Closed

fn:iterate-while → fn:while-do, fn:do-until #946

ChristianGruen opened this issue Jan 12, 2024 · 0 comments
Labels
Enhancement A change or improvement to an existing feature XQFO An issue related to Functions and Operators

Comments

@ChristianGruen
Copy link
Contributor

ChristianGruen commented Jan 12, 2024 •
edited
Loading

First feedback shows that fn:iterate-while is helpful, but the name needs to be improved: It implies that the first iteration occurs before the invocation of the test… Which could sometimes be helpful, too.

I suggest renaming the function to fn:while-do (“do” is commonly used when while loops are specified), and adding fn:do-until.
@ChristianGruen ChristianGruen added XQFO An issue related to Functions and Operators Editorial Minor typos, wording clarifications, example fixes, etc. labels Jan 12, 2024
@ChristianGruen ChristianGruen self-assigned this Jan 19, 2024
@ChristianGruen ChristianGruen changed the title fn:iterate-while → fn:while-do, fn:do-while fn:iterate-while → fn:while-do, fn:do-until Jan 20, 2024
@ChristianGruen ChristianGruen added Tests Needed Tests need to be written or merged Enhancement A change or improvement to an existing feature and removed Editorial Minor typos, wording clarifications, example fixes, etc. labels Jan 20, 2024
@ChristianGruen ChristianGruen removed their assignment Jan 20, 2024
@ChristianGruen ChristianGruen mentioned this issue Jan 20, 2024
Merged
@ndw ndw closed this as completed in ccdd526 Jan 23, 2024
ChristianGruen added a commit to qt4cg/qt4tests that referenced this issue Jan 23, 2024
@ChristianGruen
fn:iterate-while → fn:while-do, fn:do-until. qt4cg/qtspecs#946
7e29d5f
@ChristianGruen ChristianGruen removed the Tests Needed Tests need to be written or merged label Jan 23, 2024
@ChristianGruen ChristianGruen mentioned this issue May 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement A change or improvement to an existing feature XQFO An issue related to Functions and Operators
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChristianGruen