Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accurately display mute status when using volume icon or emoji #4871

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

SandaruLJ
Copy link
Contributor

I noticed that when using emojis/icons in the Volume widget, it only displays the mute symbol when the volume level is 0. It disregards the actual mute status of the device altogether and only reacts to the volume level, which I found a bit misleading.

This PR fixes it by checking mute status in addition to volume when updating the widget.

Please let me know if any changes should be done.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Qtile!
If you have not heard from us in a while, please feel free to ping one of the devs or anyone who has commented on the PR, as sometimes things fall through the cracks.
You can also join the chat room for real-time discussion, see the community links.
For details on what PRs might need to include before we will merge them please see the docs.

@tych0
Copy link
Member

tych0 commented Jun 10, 2024

hmm:

   Downloading pywlroots-0.17.0-cp312-cp312-manylinux_2_28_x86_64.whl (10.7 MB)
     ━━━━━━━━━━━━━━━╸                         4.2/10.7 MB 2.0 MB/s eta 0:00:04
  ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
      unknown package:
          Expected sha256 25f589d719a230962a6a95a0d8e7082a635113411dc7f47477cefa88a351a993
               Got        9a865f6ca46b088087d6d4a37bf30d75f034a86aad52c297421a6b590c9d26fe

seems unrelated, let me re-run.

@tych0 tych0 merged commit 28bca12 into qtile:master Jun 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants