feat: configurable panel for console + ai assistant #1267
Conversation
jimniels
commented
Apr 8, 2024
•
jimniels
commented
- Allows the positioning of the console + ai assistant to be configurable, either underneath the code editor, or to the left of it.
- Updates some mui components to use shadcn
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -10,7 +10,7 @@ class HTMLCellsHandler { | |||
| private div?: HTMLDivElement; | |||
|
|
|||
| attach(parent: HTMLDivElement) { | |||
| if (this.div) { | |||
| if (this.div && parent) { | |||
There was a problem hiding this comment.
This is breaking HMR, so I added this and now it works.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
=======================================
Coverage 89.00% 89.00%
=======================================
Files 156 156
Lines 25865 25865
=======================================
Hits 23021 23021
Misses 2844 2844 ☔ View full report in Codecov by Sentry. |
|
This branch needs to merge in main. I went through the code and the UI and everything acts as expected. I don't have great vision, so the copy was hard to read, but it's the same as before (CMD + only zooms in the grid). I wasn't familiar with the intent of the asterisk next to |
There was a problem hiding this comment.
Approved, but @davidkircos will review/approve before merging.
|
FWIW: I filed a separate issue for the font size increase/decrease discrepancies. These are bugs that exist today and aren't necessarily introduced by this PR. |
