Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved code UI treatment #997

Merged
merged 17 commits into from
Jan 22, 2024
Merged

Improved code UI treatment #997

merged 17 commits into from
Jan 22, 2024

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Jan 20, 2024

  • improve showCellTypeOutlines = false behavior
  • peek at code when hovering
  • add Spill Error information to the code's console
Screenshot 2024-01-20 at 5 58 26 AM

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Jan 22, 2024 7:29pm

@davidfig davidfig changed the base branch from main to a-team January 20, 2024 13:59
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-997 January 20, 2024 13:59 Inactive
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b8a2c31) 89.85% compared to head (25dd8a3) 89.87%.

Files Patch % Lines
quadratic-core/src/grid/sheet/rendering.rs 0.00% 2 Missing ⚠️
quadratic-core/src/grid/sheet/code.rs 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           a-team     #997      +/-   ##
==========================================
+ Coverage   89.85%   89.87%   +0.02%     
==========================================
  Files         124      124              
  Lines       21444    21487      +43     
==========================================
+ Hits        19268    19311      +43     
  Misses       2176     2176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luke-quadratic
Copy link
Contributor

This is brilliant.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-997 January 21, 2024 14:25 Inactive
@davidfig davidfig changed the title Code triangles Improved code UI treatment Jan 21, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-997 January 21, 2024 14:56 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-997 January 21, 2024 16:24 Inactive
Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tool tip text on switch, then good to merge

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-997 January 22, 2024 19:18 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-997 January 22, 2024 19:21 Inactive
@davidfig davidfig merged commit a3cac1e into a-team Jan 22, 2024
8 of 12 checks passed
@davidfig davidfig deleted the code-triangles branch January 22, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants