Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add demo for Jordan-Wigner and Bravyi-Kitaev transforms #263

Merged
merged 42 commits into from
Mar 24, 2018
Merged

Add demo for Jordan-Wigner and Bravyi-Kitaev transforms #263

merged 42 commits into from
Mar 24, 2018

Conversation

kevinsung
Copy link
Collaborator

@kevinsung kevinsung commented Mar 19, 2018 •
edited
Loading

Partially addresses #222 . I think it makes sense to have the Jordan-Wigner and Bravyi-Kitaev transforms in their own demo notebook, with the other more exotic transforms in another one. I took a very pedagogical approach which I think will be helpful to people new to the topic. Of course, feedback on the presentation is welcome.

Some content might need to be changed depending on how #259 is resolved.

@kevinsung
define eq for SymbolicOperator
7f2cf32
@kevinsung
add transforms notebook
423441e
@kevinsung
add reference to code transforms notebook
6b5c046
@kevinsung
add computation cell to first section
eb1e636
@kevinsung
Merge branch 'eq' into transforms_demo
1d4b1e3
@kevinsung
add comments
7516fb9
@kevinsung
fix annihilation operator action
907c80c
@kevinsung
explain bitstring mapping and remove macros
1daa11f
@kevinsung
fix indices in basis vectors
e74d307
@kevinsung
remove redundant reference to nielsen
5e5f0c6
@kevinsung
can't use frac shortcut
07e6d4b
@kevinsung
rename variable a_2 to annihilate_2
13301de
@kevinsung
rename variable a_2 to annihilate_2
bc640bc
@kevinsung
remove code block with normal-ordering from first section
9fa57f3
@kevinsung
expand parity section
283079b
@kevinsung
expand parity section
793b01c
@kevinsung
expand parity section
b0478c3
@kevinsung
update branch to include binary code transforms fix
eb2c5ac
@kevinsung
finish? parity section
7c748e0
@kevinsung
begin bravyi-kitaev
f5c1792
@kevinsung
wording
98ec81d
@kevinsung
expand bk section
1964264
@kevinsung
expand bk section
fc444e6
@kevinsung
add code to bk section
a170682
@kevinsung
finish? bravyi kitaev sction
230a431
@kevinsung
wording
f4e173b
@kevinsung
formatting
e1d875f
@kevinsung
fix 1/2 factor
17ea8d5
@kevinsung
change definition of parity set
da0e048
@kevinsung
restrict to Jordan-Wigner and Bravyi-Kitaev
b68582d
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@babbush
Copy link
Contributor

babbush commented Mar 20, 2018

@kevinsung I guess this needs to be merged after the eq PR?

@kevinsung
Copy link
Collaborator Author

Indeed, and preferably after resolving #259 too. I understand #259 might need more input from people though and we don't need to wait.

@babbush
Copy link
Contributor

babbush commented Mar 24, 2018

Is this good to go?

@kevinsung
Copy link
Collaborator Author

Not yet, I'll make the necessary changes and let you know when.

@kevinsung
Copy link
Collaborator Author

Ready once checks pass!

@kevinsung
Copy link
Collaborator Author

kevinsung commented Mar 24, 2018 •
edited
Loading

Wait, I realized this is not being tested, I'll fix that...

@kevinsung
Copy link
Collaborator Author

Ok ready.

@babbush babbush merged commit 29ac2c8 into quantumlib:master Mar 24, 2018
@kevinsung kevinsung deleted the transforms_demo branch March 24, 2018 01:57
philipp-q pushed a commit to philipp-q/OpenFermion that referenced this pull request Sep 2, 2020
@kevinsung @babbush
Add demo for Jordan-Wigner and Bravyi-Kitaev transforms (quantumlib#263)
b033c5b 
* define eq for SymbolicOperator

* add transforms notebook

* add reference to code transforms notebook

* add computation cell to first section

* add comments

* fix annihilation operator action

* explain bitstring mapping and remove macros

* fix indices in basis vectors

* remove redundant reference to nielsen

* can't use frac shortcut

* rename variable a_2 to annihilate_2

* rename variable a_2 to annihilate_2

* remove code block with normal-ordering from first section

* expand parity section

* expand parity section

* expand parity section

* finish? parity section

* begin bravyi-kitaev

* wording

* expand bk section

* expand bk section

* add code to bk section

* finish? bravyi kitaev sction

* wording

* formatting

* fix 1/2 factor

* change definition of parity set

* restrict to Jordan-Wigner and Bravyi-Kitaev

* remove warnings

* add automatic testing cell

* add commas

* update bravyi-kitaev section to account for implementation change

* test the demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinsung @googlebot @babbush