Add context attributes to the AuthenticationRequest interface #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @stuartwdouglas @sberyozkin |
stuartwdouglas
requested changes
Jan 26, 2021
src/main/java/io/quarkus/security/identity/request/BaseAuthenticationRequest.java
Outdated
Show resolved
Hide resolved
… derived classes.
renegrob
force-pushed
the
authentication-request-attributes
branch
from
c54dc4f to
1c0b46b
Compare
|
@stuartwdouglas Is it okay to set this PR to ready for review? |
stuartwdouglas
approved these changes
Feb 2, 2021
|
LGTM thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12
This PR adds context attributes to the AuthenticationRequest interface. The attributes are designed similar to those defined on the SecurityIdentity interface. Since AuthenticationRequests are used to transport information and short lived I don't see a problem making the attributes mutable. If the attributes were immutable, the whole object would have to be copied in order to add an attribute after the AuthenticationRequests has been created.