Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of @Inject for @ConfigProperty #1315

Closed
michalszynkiewicz opened this issue Mar 7, 2019 · 1 comment
Closed

Get rid of @Inject for @ConfigProperty #1315

michalszynkiewicz opened this issue Mar 7, 2019 · 1 comment
Assignees
@manovotn
Labels
kind/enhancement New feature or request
Milestone
0.12.0

Comments

@michalszynkiewicz
Copy link
Member

Since @ConfigProperty is used only for injecting configuration values, it seems redundant to require user to add @Inject with it.
This issue is to make @Inject optional for @ConfigProperty's
@mkouba mkouba changed the title Get rid of @Inject for @ConfigProperty Get rid of @Inject for @ConfigProperty Mar 7, 2019
@mkouba mkouba added the kind/enhancement New feature or request label Mar 7, 2019
@geoand
Copy link
Contributor

geoand commented Mar 7, 2019

This makes sense to me as well.

FWIW in Spring you only need @Value, no need to add @Autowired

@manovotn manovotn self-assigned this Mar 18, 2019
manovotn added a commit to manovotn/quarkus that referenced this issue Mar 18, 2019
@manovotn
Allow for usage of @ConfigProperty on fields without the need for @In…
807f37c 
…ject.

Fixes quarkusio#1315.
@mkouba mkouba added this to the 0.12.0 milestone Mar 18, 2019
@mkouba mkouba closed this as completed in 5805d49 Mar 18, 2019
geoand added a commit to geoand/quarkus that referenced this issue Mar 18, 2019
@geoand
Remove now unnecessary @Inject on @ConfigProperty
18d9665 
quarkusio#1554 made it redundant to have @Inject on a @ConfigProperty

Follows up on: quarkusio#1315
@geoand geoand mentioned this issue Mar 18, 2019
Merged
geoand added a commit to geoand/quarkus that referenced this issue Mar 18, 2019
@geoand
Remove now unnecessary @Inject on @ConfigProperty
905dd5f 
quarkusio#1554 made it redundant to have @Inject on a @ConfigProperty

Follows up on: quarkusio#1315
vorburger added a commit to vorburger/quarkus that referenced this issue Mar 18, 2019
@vorburger
Merge branch 'master' into issue-304_s2i-native-DEV
387df05 
* master: (167 commits)
  Allow for usage of @ConfigProperty on fields without the need for @Inject. Fixes quarkusio#1315.
  Expose all flavors (core, axle, rx) of Vert.x EventBus
  RestClient - passing incoming JAX-RS headers, fixes quarkusio#1017
  JAX-RS body writers for Vert.x JsonObject and JsonArray
  Increase CI memory
  PathTestHelper should accept default Gradle build paths now + make sure we run the test in gradle-it
  Change to use ./mvnw
  Update opentracing guide to describe using application.properties as alternative to env vars
  fix npe in dev mode when source is missing in recompilation diagnostic
  Add the quarkus-elytron-security component in the BOM
  Moves the logic that handles the registration of schema class for serialization in smallrye-openapi-extension
  Add Maven Wrapper to generated projects
  [security extension] - AuthConfig only configured if IdentityManager is produced
  quarkusio#1522 Warning to keep H2 version as is
  Minor corrections to mx and git repo clone instructions.
  programmatic client generation for MP Rest Client, fixes quarkusio#1317
  Hibernate ORM - Fix config property name in error message
  Camel - Use a constant for Camel root package directory
  Micro version updates
  JAX-RS Generate reflection declaration from MP OpenAPI schema definition
  ...
maxandersen pushed a commit to maxandersen/quarkus that referenced this issue Nov 5, 2022
@davsclaus
Update copyright year to 2022 (quarkusio#1315)
211f020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manovotn manovotn

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
4 participants
@mkouba @michalszynkiewicz @manovotn @geoand