Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native runner binary should have platform encoded #18660

Open
maxandersen opened this issue Jul 13, 2021 · 2 comments
Open

native runner binary should have platform encoded #18660

maxandersen opened this issue Jul 13, 2021 · 2 comments
Labels
area/native-image env/windows Impacts Windows machines kind/enhancement New feature or request

Comments

@maxandersen
Copy link
Member

currently the runner gets named something like: quarkus-cli-999-SNAPSHOT-runner.jar i.e. project-version-runner.jar

For the .jar that is fine, but for the native executable its unfortunate - especially on windows and mac since if I do:

mvn package -Pnative I get a OSX executable named quarkus-cli-999-SNAPSHOT-runner but I get the a ELF/linux binary when doing mvn package -Dquarkus.native.container-build=true also with same name.

we should use the format project-version-platform-runner.jar so it would something like quarkus-cli-999-SNAPSHOT-darwin-runner for osx and quarkus-cli-999-SNAPSHOT-win64-runner.exe for windows and similar for linux.

Then it is explicit and when you do multiple builds in i.e. github action or on win/osx you end up with actual separate binaries per platform rather than overwriting.

note: just using darwin and win64 as examples - there is a convention I just don't recall it by heart :)

@quarkus-bot quarkus-bot bot added the env/windows Impacts Windows machines label Jul 13, 2021
@aalmiray
Copy link
Contributor

Please use the same platform names as detected by https://github.com/trustin/os-maven-plugin

@maxandersen
Copy link
Member Author

this was actually not done.

@maxandersen maxandersen reopened this Jan 26, 2025
@zakkak zakkak added the kind/enhancement New feature or request label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/native-image env/windows Impacts Windows machines kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants