Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Multi<Byte> and Multi<byte[]> for octet stream in Rest Client Reactive #20024

Closed
michalszynkiewicz opened this issue Sep 9, 2021 · 5 comments · Fixed by #39285
Closed

Support Multi<Byte> and Multi<byte[]> for octet stream in Rest Client Reactive #20024

michalszynkiewicz opened this issue Sep 9, 2021 · 5 comments · Fixed by #39285
Labels
area/rest-client kind/enhancement New feature or request
Milestone
3.9.0.CR1

Comments

@michalszynkiewicz
Copy link
Member

Description

REST Client Reactive should be able to parse binary data to Multi<Byte> and/or Multi<byte[]> (where one batches of bytes roughly correspond to chunks of HTTP data)

CC @cescoffier

Implementation ideas

No response
@michalszynkiewicz michalszynkiewicz added the kind/enhancement New feature or request label Sep 9, 2021
@geoand
Copy link
Contributor

geoand commented Mar 7, 2024

@cescoffier @jponge I am pretty sure we could support this by turning Multi<Byte> and Multi<byte[]> into a Vertx ReadStream.

Is there any such converter anywhere?

@jponge
Copy link
Member

jponge commented Mar 7, 2024

https://github.com/smallrye/smallrye-mutiny-vertx-bindings/blob/main/vertx-mutiny-clients/vertx-mutiny-runtime/src/main/java/io/smallrye/mutiny/vertx/ReadStreamSubscriber.java#L20

@geoand
Copy link
Contributor

geoand commented Mar 7, 2024

Oh, that's nice!

@geoand
Copy link
Contributor

geoand commented Mar 8, 2024

I'll have a look at this after #39265 is in

geoand added a commit to geoand/quarkus that referenced this issue Mar 8, 2024
@geoand
Support sending Multi<io.vertx.mutiny.core.buffer.Buffer> in REST Client
c243101 
Closes: quarkusio#20024
@geoand geoand mentioned this issue Mar 8, 2024
Merged
@geoand
Copy link
Contributor

geoand commented Mar 8, 2024

It makes much sense to support Multi<io.vertx.mutiny.core.buffer.Buffer> due to the fact that this is what we can get from the various Vert.x Mutiny APIs so that is what #39285 does.

geoand added a commit to geoand/quarkus that referenced this issue Mar 8, 2024
@geoand
Support sending Multi<io.vertx.mutiny.core.buffer.Buffer> in REST Client
dad1a42 
Closes: quarkusio#20024
geoand added a commit to geoand/quarkus that referenced this issue Mar 11, 2024
@geoand
Support sending Multi<io.vertx.mutiny.core.buffer.Buffer> in REST Client
b5f3394 
Closes: quarkusio#20024
geoand added a commit that referenced this issue Mar 11, 2024
@geoand
Merge pull request #39285 from geoand/#20024
5c25ff5 
Support sending Multi<io.vertx.mutiny.core.buffer.Buffer> in REST Client
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/rest-client kind/enhancement New feature or request
Projects
None yet
Milestone
3.9.0.CR1
Development

Successfully merging a pull request may close this issue.

Support sending Multi<io.vertx.mutiny.core.buffer.Buffer> in REST Client geoand/quarkus
3 participants
@jponge @michalszynkiewicz @geoand