Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support not supplying a value for name in Spring Web @PathVariable #3992

Closed
geoand opened this issue Sep 12, 2019 · 8 comments
Closed

Support not supplying a value for name in Spring Web @PathVariable #3992

geoand opened this issue Sep 12, 2019 · 8 comments
Assignees
Labels
area/spring Issues relating to the Spring integration kind/bug Something isn't working triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@geoand
Copy link
Contributor

geoand commented Sep 12, 2019

In the current Quarkus integration when using Spring Web's @PathVariable one needs to supply a value for name (or value which is an alias) like so:

    public Greeting greet(@PathVariable(name = "message") String message) {
...
    }

In Spring Web this is not absolutely necessary because Spring can use the method parameter name (if the -parameter flag has been supplied during source code compilation).
We should try and do the same.

See: quarkusio/quarkusio.github.io#289

@geoand geoand added kind/bug Something isn't working area/spring Issues relating to the Spring integration labels Sep 12, 2019
@geoand geoand assigned geoand and unassigned geoand Sep 12, 2019
@geoand
Copy link
Contributor Author

geoand commented Sep 12, 2019

@aureamunoz up to you :)

@geoand
Copy link
Contributor Author

geoand commented Sep 12, 2019

Same probably goes for @RequestParam

@aureamunoz
Copy link
Member

Ok. I will take a look!

@geoand
Copy link
Contributor Author

geoand commented Sep 13, 2019

The change will be in the RESTEasy codebase - let me know when you look into this so I can point you in the right direction

@jclingan
Copy link

jclingan commented Sep 28, 2019

BTW, I can confirm that @RequestParam requires a name attribute.

@aureamunoz
Copy link
Member

fixed in part on RESTEasy PR 2177

aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Oct 8, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Oct 8, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Oct 9, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Oct 9, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Oct 9, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Oct 10, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Oct 10, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Oct 10, 2019
CSTDev pushed a commit to CSTDev/quarkus that referenced this issue Oct 22, 2019
dufoli pushed a commit to dufoli/quarkus that referenced this issue Oct 23, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Oct 29, 2019
@stale
Copy link

stale bot commented Nov 13, 2019

This issue/pullrequest has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2019
@geoand
Copy link
Contributor Author

geoand commented Nov 13, 2019

This has already been implemented

@geoand geoand closed this as completed Nov 13, 2019
@gsmet gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Nov 13, 2019
mmusgrov pushed a commit to mmusgrov/quarkus that referenced this issue Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/spring Issues relating to the Spring integration kind/bug Something isn't working triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

No branches or pull requests

4 participants