Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide actionable information when EntityManager is not available in Hibernate Panache #13342

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Provide actionable information when EntityManager is not available in Hibernate Panache #13342

merged 1 commit into from
Nov 17, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Nov 17, 2020 •
edited
Loading

Fixes: #13324
Fixes: #13338

@ghost ghost added the area/panache label Nov 17, 2020
@geoand
Copy link
Contributor Author

geoand commented Nov 17, 2020

Supersedes : #13260

@geoand geoand mentioned this pull request Nov 17, 2020
Closed
@geoand geoand force-pushed the #13324 branch 2 times, most recently from 6a0ff72 to d55744d Compare November 17, 2020 11:52
FroMage
FroMage previously requested changes Nov 17, 2020
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine, but we should add QuarkusUnitTest for those scenarios, so that they don't fail again.

@geoand
Copy link
Contributor Author

geoand commented Nov 17, 2020

Makes sense. I'll add one

@geoand
Copy link
Contributor Author

geoand commented Nov 17, 2020

Test added

@geoand geoand requested a review from FroMage November 17, 2020 14:04
FroMage
FroMage approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK great, thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 17, 2020
@geoand geoand merged commit 4d73b25 into quarkusio:master Nov 17, 2020
@ghost ghost added this to the 1.11 - master milestone Nov 17, 2020
@geoand geoand deleted the #13324 branch November 17, 2020 17:41
@gsmet gsmet modified the milestones: 1.11 - master, 1.10.0.Final Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
area/panache triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.10.0.Final
3 participants
@geoand @FroMage @gsmet