Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Quarkus Maven plugin smart create consistent with codestarts #13346

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Nov 17, 2020

Fixes #13272

Change the interactive questions when legacyCodegen is not used:

Set the project groupId [org.acme]: 
Set the project artifactId [code-with-quarkus]: 
Set the project version [1.0.0-SNAPSHOT]: 
What extensions do you wish to add (comma separated list): [resteasy]
Do you want example code to get started (yes), or just an empty project (no) [yes]?

Change the defaults in the Quarkus Maven plugin to be consistent with code.quarkus.io:

  • groupId -> org.acme
  • artifactId -> code-with-quarkus
  • version -> 1.0.0-SNAPSHOT

Deprecate the className parameter in the Quarkus Maven plugin and introduce the packageName instead (defaulted to groupId).

@ghost ghost added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Nov 17, 2020
@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 17, 2020

cc @gsmet

@ia3andy ia3andy force-pushed the consistant-mvn-plugin branch 4 times, most recently from c281d1b to 57918d2 Compare November 18, 2020 08:32
@ia3andy ia3andy changed the title Make Quarkus Maven plugin smart create consistant with codestarts Make Quarkus Maven plugin smart create consistent with codestarts Nov 18, 2020
@aloubyansky
Copy link
Member

Looks good. I have to admit I've got used to the "include rest example? yes/no", which i would always approve with 'y', btw. With this change I would have to type in resteasy and then confirm I want the example, right?
I get the reasons though behind this PR. I guess we could have a choice like
Extensions to add (none, <extension>(,<extension>)*) [resteasy]:
but perhaps it's too confusing.

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 18, 2020

Looks good. I have to admit I've got used to the "include rest example? yes/no", which i would always approve with 'y', btw. With this change I would have to type in resteasy and then confirm I want the example, right?

@aloubyansky You can still use y, n or no or even nope ^^ I check for startWith("n"), but since yes is the default, you can also just type enter if you want the examples.

So if you want the REST example, then it's enter then enter (even simpler) :)

I get the reasons though behind this PR. I guess we could have a choice like
Extensions to add (none, <extension>(,<extension>)*) [resteasy]:
but perhaps it's too confusing.

RESTEasy is auto added when you don't select any extension ([]) so I guess it's alright as is?

I wouldn't be against adding it as the default choice [resteasy], the behavior would be the exact same..

@aloubyansky
Copy link
Member

Ah, so that [] looked like nothing would be added by default. So then how can I deselect resteasy? If I type anything that's not resteasy, it will replace resteasy with what I typed in?

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 18, 2020

Ah, so that [] looked like nothing would be added by default. So then how can I deselect resteasy? If I type anything that's not resteasy, it will replace resteasy with what I typed in?

@aloubyansky RESTEasy is only added when there is no other extension containing an example selected. In other words as soon as you type another extension that includes an example, resteasy is not added unless you added it.

@aloubyansky
Copy link
Member

I think it'd be good to indicate that the resteasy is added by default if no other input is provided.

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 18, 2020

I think it'd be good to indicate that the resteasy is added by default if no other input is provided.

@aloubyansky ok done :)

@ia3andy ia3andy merged commit 6903b66 into quarkusio:master Nov 18, 2020
@ghost ghost added this to the 1.11 - master milestone Nov 18, 2020
@ia3andy ia3andy deleted the consistant-mvn-plugin branch November 18, 2020 12:38
@ghost
Copy link

ghost commented Nov 18, 2020

Milestone is already set for some of the items:

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Quarkus Maven plugin smart "create" consistent with codestarts
3 participants