Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote the usage of the Maven wrapper in the instructions #1496

Merged

Conversation

jnizet
Copy link
Contributor

@jnizet jnizet commented Mar 14, 2019

This makes sure everyone (hopefully) uses the same, correct Maven version, makes it easier to setup the development environment and to contribute.

This makes sure everyone (hopefully) uses the same, correct Maven version, makes it easier to setup the development environment and to contribute.
@geoand
Copy link
Contributor

geoand commented Mar 14, 2019

@jnizet This is a great idea IMHO, but I think that it will cause confusion because currently our generated projects don't include the maven wrapper.
Would you like to augment the PR to add the wrapper as well?
See this and this

@jnizet
Copy link
Contributor Author

jnizet commented Mar 14, 2019

I'll have a look tomorrow. But could you explain what these generated projects are, and how, when and where they are generated?
I found it weird to have the Maven wrapper in the main project, but not to tell contributors to use it: that defeats the whole purpose of having the wrapper.

@geoand
Copy link
Contributor

geoand commented Mar 14, 2019

@jnizet Sorry, I thought the PR was about the guides, not Quarkus itself! My bad :(!
Please consider my comment above as it never happened.

Although you did give me an idea to add that wrapper to the quickstarts and the created projects :)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks.

@gsmet gsmet merged commit 0af24da into quarkusio:master Mar 14, 2019
@gsmet gsmet added this to the 0.12.0 milestone Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants