-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix card layout in Dev UI #16985
Fix card layout in Dev UI #16985
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building c3aed16
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 core/test-extension/deployment✖ ⚙️ JVM Tests - JDK 11 Windows #📦 core/test-extension/deployment✖ ⚙️ JVM Tests - JDK 15 #📦 core/test-extension/deployment✖ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added a couple of questions/comments.
<a href="{it['metadata']['guide']}" class="text-muted float-right" title="Guide"><i class="fa fa-book"></i></a> | ||
{/if} | ||
<div class="row"> | ||
<div class="col-md-10"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why, but if I put 11, the button guide ends up going down.
I think it ends up leaving the limits of the bootstrap grid.
<div class="col-md-10"> | ||
{it['name']} | ||
</div> | ||
<div class="col-md-1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see, the icon is significantly more to the left. Could we adjust that with some alignment and padding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, good thanks!
@gsmet , can we merge? |
Yes, thanks! |
always keep the guide button on the right side.
Before
After