Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix card layout in Dev UI #16985

Merged
merged 2 commits into from
May 7, 2021
Merged

Fix card layout in Dev UI #16985

merged 2 commits into from
May 7, 2021

Conversation

netodevel
Copy link
Contributor

always keep the guide button on the right side.

Before

antes

After

after

@quarkus-bot
Copy link

quarkus-bot bot commented May 5, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c3aed16

Status Name Step Test failures Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 core/test-extension/deployment

io.quarkus.extest.ConfiguredBeanTest.testConfigDefaultValuesSourceOrdinal line 346 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 core/test-extension/deployment

io.quarkus.extest.ConfiguredBeanTest.testConfigDefaultValuesSourceOrdinal line 346 - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 core/test-extension/deployment

io.quarkus.extest.ConfiguredBeanTest.testConfigDefaultValuesSourceOrdinal line 346 - More details - Source on GitHub

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a couple of questions/comments.

<a href="{it['metadata']['guide']}" class="text-muted float-right" title="Guide"><i class="fa fa-book"></i></a>
{/if}
<div class="row">
<div class="col-md-10">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 11?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why, but if I put 11, the button guide ends up going down.
I think it ends up leaving the limits of the bootstrap grid.

<div class="col-md-10">
{it['name']}
</div>
<div class="col-md-1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, the icon is significantly more to the left. Could we adjust that with some alignment and padding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

padding done

after-style

@gsmet gsmet changed the title Fixs card layout Fix card layout in Dev UI May 6, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good thanks!

@netodevel
Copy link
Contributor Author

@gsmet , can we merge?

@gsmet gsmet merged commit 1d3e2c7 into quarkusio:main May 7, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 7, 2021
@gsmet
Copy link
Member

gsmet commented May 7, 2021

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants