Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about DevServices in Redis documentation #17132

Merged
merged 1 commit into from
May 11, 2021
Merged

Add information about DevServices in Redis documentation #17132

merged 1 commit into from
May 11, 2021

Conversation

netodevel
Copy link
Contributor

Adds properties available to customize the redis testcontainer.

Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition @netodevel I added a small suggestion.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added a small suggestion too.

docs/src/main/asciidoc/redis.adoc Outdated Show resolved Hide resolved
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you squash then it should be good to merge?

@gsmet gsmet changed the title Updated redis docs Add information about DevServices in Redis documentation May 11, 2021
@gsmet
Copy link
Member

gsmet commented May 11, 2021

I pushed the squash, let's wait for CI and merge.

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the generated asciidoc instead:

include::{generated-dir}/config/quarkus-redis-client-config-group-dev-services-config.adoc[opts=optional, leveloffset=+1]

@netodevel
Copy link
Contributor Author

@gastaldi, sorry I did not understand.
I need to create a separate specific file containing only redis-devservices configs
and then do an include in that redis.adoc?

@gastaldi
Copy link
Contributor

gastaldi commented May 11, 2021

I need to create a separate specific file containing only redis-devservices configs
and then do an include in that redis.adoc?

No, this file is generated automatically when you build the project. If you include that line you'll see something like this:

image

@netodevel
Copy link
Contributor Author

@gastaldi, got it, i added the include.

@gastaldi
Copy link
Contributor

Can you please squash your commits before we merge it?

@netodevel
Copy link
Contributor Author

@gastaldi, the first time I did squash, please check that I did it correctly 😄

@gastaldi
Copy link
Contributor

Your commit message is weird. You can fix this by doing git commit --amend

@netodevel
Copy link
Contributor Author

netodevel commented May 11, 2021

@gastaldi, done

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job!

@gastaldi gastaldi merged commit 17c6cab into quarkusio:main May 11, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants