Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds redis-devservices it #17133

Merged
merged 1 commit into from
May 13, 2021
Merged

Adds redis-devservices it #17133

merged 1 commit into from
May 13, 2021

Conversation

netodevel
Copy link
Contributor

Adds feature integration tests of redis.devservices
To guarantee the functioning of the resource.

@quarkus-bot
Copy link

quarkus-bot bot commented May 11, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building a04cb83

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 11, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 86ae778

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Cache Maven Repository ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 11, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 7c8f2ca

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@geoand geoand requested a review from machi1990 May 11, 2021 07:15
machi1990
machi1990 requested changes May 11, 2021
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful addition. Thanks @netodevel, I left some comments.

netodevel
netodevel commented May 11, 2021
View reviewed changes
Copy link
Contributor Author

@netodevel netodevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@machi1990, I made the changes, when I can resolve let me know.

integration-tests/redis-devservices/src/test/resources/application.properties Outdated Show resolved Hide resolved
@quarkus-bot
Copy link

quarkus-bot bot commented May 11, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 6ed50d4

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Persist Maven Repo ⚠️ Check → Logs Raw logs

@netodevel
Copy link
Contributor Author

@machi1990, when you can review again

@machi1990
Copy link
Member

@machi1990, when you can review again

LGTM. Can you squash, once it is done I'll merge this PR? Thanks for the great work!

@netodevel
Copy link
Contributor Author

@machi1990, when you can review again

LGTM. Can you squash, once it is done I'll merge this PR? Thanks for the great work!

Squash done! Thanks for the review.

machi1990
machi1990 approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition. LGTM.

@machi1990 machi1990 added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 12, 2021
@netodevel
Copy link
Contributor Author

Thanks for the addition. LGTM.

CI passed, lgtm?
🚀

@gastaldi gastaldi merged commit fb5d886 into quarkusio:main May 13, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 13, 2021
@netodevel
Copy link
Contributor Author

@machi1990,
I was thinking about adding these integration tests to all other devservices, what do you think?

To do this I would like to reuse this class: https://github.com/quarkusio/quarkus/blob/c5e430c0425895adc97b85df0978617859b4998c/integration-tests/redis-devservices/src/test/java/io/quarkus/redis/devservices/it/utils/SocketKit.java

Which module do you think this class should stay?

@netodevel netodevel mentioned this pull request Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0.Alpha3
Development

Successfully merging this pull request may close these issues.
3 participants
@netodevel @machi1990 @gastaldi