Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAX-RS body readers for Vert.x JsonObject and JsonArray #1826

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

tsegismont
Copy link
Contributor

This allows to use Vert.x JsonObject and JsonArray as JAX-RS request content.

As many Vert.x client APIs take json content (e.g. Mongo client), this might be handy.

@tsegismont
Copy link
Contributor Author

@FroMage @cescoffier can one of you please review? Thanks.

This follows-up on #1549

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an interesting addition. There's an issue with the dependencies though.

I'll let other people review it in more details, I just made a quick scan.

integration-tests/vertx/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided the provided issue raised by @gsmet is fixed.

@tsegismont
Copy link
Contributor Author

@gsmet @FroMage thank you both for reviewing.

@FroMage do you mean it's been fixed in master and I only need to rebase the PR?

This allows to use Vert.x JsonObject and JsonArray as JAX-RS request content.

As many Vert.x client APIs take json content (e.g. Mongo client), this might be handy.
@gsmet
Copy link
Member

gsmet commented Apr 3, 2019

Let's wait for CI and merge.

@gsmet gsmet added this to the 0.13.0 milestone Apr 3, 2019
@gsmet
Copy link
Member

gsmet commented Apr 3, 2019

And merged! Thanks!

@gsmet gsmet merged commit 56cb55a into quarkusio:master Apr 3, 2019
@tsegismont tsegismont deleted the vertx-json-input branch April 11, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants