Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bootstrap dependency issue: always add Maven Central repo unless it's already configured #1946

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Fix bootstrap dependency issue: always add Maven Central repo unless it's already configured #1946

merged 1 commit into from
Apr 9, 2019

Conversation

aloubyansky
Copy link
Member

Fix for #1918
This commit adds the central repo unless it's already present among the repos (to be consistent with the maven default repo initialization).

@aloubyansky aloubyansky requested a review from gsmet April 9, 2019 11:29
@aloubyansky aloubyansky self-assigned this Apr 9, 2019
gsmet
gsmet approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Let's wait for CI and merge.

@geoand
Copy link
Contributor

geoand commented Apr 9, 2019

All green

@gsmet gsmet added this to the 0.13.1 milestone Apr 9, 2019
@gsmet gsmet merged commit 9af80d5 into quarkusio:master Apr 9, 2019
@gsmet
Copy link
Member

gsmet commented Apr 9, 2019

Thanks @aloubyansky

@gsmet gsmet changed the title Fix for #1918, always add central maven repo unless it's already configured Fix bootstrap dependency issue: always add Maven Central repo unless it's already configured Apr 9, 2019
@gsmet gsmet added release/noteworthy-feature kind/bug Something isn't working labels Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees

@aloubyansky aloubyansky

Labels
kind/bug Something isn't working release/noteworthy-feature
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.
3 participants
@aloubyansky @geoand @gsmet