Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to smallrye-jwt 1.1.4 and remove CDI producers #2300

Merged
merged 3 commits into from
May 9, 2019
Merged

Update to smallrye-jwt 1.1.4 and remove CDI producers #2300

merged 3 commits into from
May 9, 2019

Conversation

sberyozkin
Copy link
Member

The CDI producers code from Quarkus and Thorntail smallrye-jwt extensions has been moved to smallrye-jwt, see smallrye/smallrye-jwt#42

@sberyozkin sberyozkin mentioned this pull request Apr 30, 2019
Merged
gsmet
gsmet previously requested changes Apr 30, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We sure do not want SNAPSHOT dependencies.

bom/pom.xml Outdated Show resolved Hide resolved
@gsmet gsmet changed the title Update to smallrye-jwt 1.1.4 [DO NOT MERGE] Update to smallrye-jwt 1.1.4 Apr 30, 2019
starksm64
starksm64 reviewed May 1, 2019
View reviewed changes
Copy link
Contributor

@starksm64 starksm64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that this works with the snapshot, so once the smallrye-jwt is ready for release, this an be updated to refer to the release and merged.

@sberyozkin sberyozkin changed the title [DO NOT MERGE] Update to smallrye-jwt 1.1.4 [DO NOT MERGE] Update to smallrye-jwt 1.1.4 and remove CDI producers May 7, 2019
@starksm64
Update pom.xml
547c721 
Update to 1.1.4 release of smallrye-jwt
@starksm64 starksm64 dismissed gsmet’s stale review May 9, 2019 01:15

This is out of date

@starksm64 starksm64 merged commit bef297a into quarkusio:master May 9, 2019
@starksm64 starksm64 changed the title [DO NOT MERGE] Update to smallrye-jwt 1.1.4 and remove CDI producers Update to smallrye-jwt 1.1.4 and remove CDI producers May 9, 2019
@gsmet gsmet added this to the 0.15.0 milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@starksm64 starksm64 starksm64 approved these changes

Assignees
No one assigned
Labels
area/security area/smallrye
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sberyozkin @starksm64 @gsmet