Manage Guava without findbugs and listenablefuture, make sure they do #23686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not soak through quarkus-maven-plugin and quarkus-bootstrap See https://issues.redhat.com/browse/QUARKUS-1742 for more details.
quarkus-bot
bot
added
area/core
area/devtools
|
Please backport to 2.7 |
|
This workflow status is outdated as a new workflow run has been triggered. |
aloubyansky
reviewed
Feb 15, 2022
| <bannedDependencies> | ||
| <excludes> | ||
| <!-- findbugs is not required at runtime --> | ||
| <exclude>com.google.code.findbugs:jsr305</exclude> |
There was a problem hiding this comment.
This dependency is managed in the quarkus-bom. It's a runtime dependency of quarkus-grpc.
There was a problem hiding this comment.
That's fine for grpc and I do not think it contradicts banning it here in quarkus-core-deployment. I mean it would be nice if findbugs does not soak to every single deployment module that depends on quarkus-core-deployment. Most, if not all deployment modules depend on quarkus-core-deployment.
If some deployment module needs findbugs, it is free to depend on it direcly. Those cases are rather rare, though.
aloubyansky
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not soak through quarkus-maven-plugin and quarkus-bootstrap
See https://issues.redhat.com/browse/QUARKUS-1742 for more details.