Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertx processor - produce ServiceStartBuildItem #2418

Merged
merged 1 commit into from
May 13, 2019
Merged

Vertx processor - produce ServiceStartBuildItem #2418

merged 1 commit into from
May 13, 2019

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 13, 2019

  • so that StartupEvent is always fired after Vertx is initialized

@mkouba mkouba requested a review from cescoffier May 13, 2019 09:11
@mkouba mkouba added this to the 0.15.0 milestone May 13, 2019
@tsegismont
Copy link
Contributor

@mkouba for my own education, what does the startup event enable for?

@mkouba
Copy link
Contributor Author

mkouba commented May 13, 2019

StartupEvent is fired when the app is starting and can be used to perform some init logic. See also https://quarkus.io/guides/application-lifecycle-events-guide.

Ah, I forgot to link the issue: #2221.

@mkouba mkouba changed the title Vetrx processor - produce ServiceStartBuildItem Vertx processor - produce ServiceStartBuildItem May 13, 2019
@mkouba
Vertx processor - produce ServiceStartBuildItem
3ede9dc 
- so that StartupEvent is always fired after Vertx is initialized
- resolves quarkusio#2221
@mkouba mkouba force-pushed the issue-2221-vertx-servicestart branch from 6471f92 to 3ede9dc Compare May 13, 2019 09:46
@gsmet gsmet merged commit 46d769c into quarkusio:master May 13, 2019
@gsmet gsmet mentioned this pull request May 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@cescoffier cescoffier Awaiting requested review from cescoffier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @tsegismont @gsmet