-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first version of Keycloak admin client based on Reactive REST Client #24300
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Wasn't the last release of keycloak enough? |
It introduced the changes we needed. This is the new extension that uses the changes and leverages the Reactive REST Client under the hood |
Ah ok, I misundertood. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to document that somewhere.
We also do not have any tests for the non-reactive version (I think @sberyozkin was working on that), but we would need some tests for this version.
The rest looks great!
I added a couple mentions in the security docs. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @geoand
YW! |
Hi @geoand @cescoffier |
I think the doc comment was addressed. As for the tests, Sergey will deal with them later AFAICS.
Quick feedback: I tried it and got a 404 error. It tries to access the URL below, where the last path element ("roles") is duplicated: I'll look at it closer and create an issue as soon as I find the time. |
I wonder, can we expect a client that uses Mutiny in the API? |
That's one for @sberyozkin and @pedroigor |
Alternative to #24294 that requires a new Keycloak release