-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make revapi report functional #26678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok... Could also please provide some rendered examples in the PR description so that we have a better idea about the reports?
@@ -3,7 +3,7 @@ | |||
<analysisConfiguration> | |||
<revapi.java> | |||
<missing-classes> | |||
<behavior>error</behavior> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specific reason why changing this?
i'm fine merging this - its miles better than current one :) just that one question on chaning from error to report I wanted to understand. |
The reason is for revapi to report missing classes not to fail the build |
Note that |
One thing that I would probably try to add is the "example use-chain" that Revapi produces for the missing classes (and other differences, see |
Thank you @metlos for your inputs. |
reason for fail/error was whne running pr builds the build would not pass if missing documentation for api changes. I thought this was the way to do so ? |
@zedbeit can you rebase this then i'll merge it and we can look at example-use-chain in separate pr? |
Ok done. |
c6f98a3
to
0fc2632
Compare
0fc2632
to
5eb7a9f
Compare
This comment has been minimized.
This comment has been minimized.
b34058e
to
c191caa
Compare
sorry did not notice the extra commits before now. Makes a big diff on the change log. awesome. |
@zedbeit can you squash the commits then we can merge it? |
Made a new PR for this here, closing this one @maxandersen |
The idea is to improve revapi reporting.
Some screenshots of how the report looks like now.