Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Oracle DB container image to new 21-slim-faststart flavour #27588

Merged
merged 1 commit into from Aug 30, 2022

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Aug 30, 2022

@gvenzl is now publishing a new kind of Oracle DB container images called "faststart" - these are slighly larger to download but are sginificantly faster to bootstrap, making them more suitable for Quarkus dev-services.

With this PR I'm making them the new default for Quarkus; the change should be transparent to end users.

Also it would seem that the slightly larger file size has negligible impact on pull times (atlhough this will likely vary from system to system); see gvenzl/oci-oracle-xe#36

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM labels Aug 30, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 30, 2022

/cc @gsmet, @yrodiere

@Sanne Sanne unassigned gsmet Aug 30, 2022
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 30, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 30, 2022

Failing Jobs - Building 6761336

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.AnnotationProcessorSimpleModuleDevModeTest.main line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 87 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.HibernateHotReloadTestCase.testImportSqlWithContinuousTesting line 87 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 3 State{lastRun=1, running=true, inProgress=false, run=1, passed=1, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.hibernate.orm.HibernateHotReloadTestCase.testImportSqlWithContinuousTesting(HibernateHotReloadTestCase.java:87)

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/oidc-token-propagation-reactive 

📦 integration-tests/oidc-token-propagation-reactive

io.quarkus.it.keycloak.OidcTokenReactivePropagationTest.testGetUserNameWithAccessTokenPropagation line 22 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 401 Unauthorized for http://localhost:8081/frontend/access-token-propagation
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:461)

io.quarkus.it.keycloak.OidcTokenReactivePropagationTest.testNoToken line 43 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <302> but was <401>.

@Sanne Sanne merged commit 8c7cce7 into quarkusio:main Aug 30, 2022
@Sanne Sanne deleted the oracle-faststart branch August 30, 2022 14:12
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 30, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devservices area/hibernate-orm Hibernate ORM area/persistence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants