Rest Data Panache: Correct Open API integration #28811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before these changes, Open API could not deduct the return type when using Response.class (in Rest Data Panache classic). Also, for Rest Data Panache reactive, the return object for the endpoint '/get' was wrongly saying that was a single entity when is an array of entities. And finally, for the update and delete endpoints, the result status code was wrong (for update should be 201 and for delete 204). After these changes, all the above issues are fixed and covered using the existing test. Fix quarkusio#28786
|
@Sgitario I tried backporting this one but it has a lot of conflicts. Either we just skip it or we need a separate PR to backport it (or we need to backport something else to make it less painful). |
|
For me, it's ok to not backport it to 2.13. This has not been working for a while, so I guess it's not an urgent change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the following issues:
Response.class(in Rest Data Panache classic).Fix #28786