Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(native): native image build fails when directory contains spaces #2882

Merged
merged 1 commit into from
Jun 19, 2019
Merged

fix(native): native image build fails when directory contains spaces #2882

merged 1 commit into from
Jun 19, 2019

Conversation

machi1990
Copy link
Member

Fixes #2830

@machi1990
Copy link
Member Author

TCKs pipeline failure seems unrelated.

@geoand
Copy link
Contributor

geoand commented Jun 19, 2019

I restarted the failed TCK job

@machi1990
Copy link
Member Author

I restarted the failed TCK job

Thanks. All green now.

FroMage
FroMage approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@FroMage FroMage merged commit 8c96fe3 into quarkusio:master Jun 19, 2019
@FroMage FroMage added the kind/bug Something isn't working label Jun 19, 2019
@FroMage FroMage added this to the 0.17.0 milestone Jun 19, 2019
@machi1990 machi1990 deleted the 2830 branch June 19, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlloyd dmlloyd dmlloyd left review comments

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

Native compilation again does't like spaces in project directory in 0.15.0 and 0.16.0 ver
4 participants
@machi1990 @geoand @dmlloyd @FroMage