Don't load Kotlin parent first #29697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
stuartwdouglas
force-pushed
the
kotlin-parent-first
branch
from
1d46434
to
73b34a6
Compare
quarkus-bot
bot
added
the
area/devtools
geoand
approved these changes
Dec 6, 2022
This comment has been minimized.
This comment has been minimized.
stuartwdouglas
changed the title
aloubyansky
reviewed
Dec 6, 2022
| protected URL findResource(String name) { | ||
| return getResource(name); | ||
| } | ||
|
|
There was a problem hiding this comment.
Looks like we are also missing Enumeration<URL> findResources(String name) impl.
stuartwdouglas
force-pushed
the
kotlin-parent-first
branch
from
73b34a6
to
02d4ec0
Compare
This comment has been minimized.
This comment has been minimized.
stuartwdouglas
force-pushed
the
kotlin-parent-first
branch
from
02d4ec0
to
1682440
Compare
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 8, 2022
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Dec 14, 2022
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Dec 15, 2022
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Dec 15, 2022
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Dec 16, 2022
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Jan 5, 2023
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Jan 6, 2023
ebullient
pushed a commit
to maxandersen/quarkus
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test PR to see what breaks if we stop loading Kotlin parent first.
I think a lot of the reasons why we needed to do this originally may no longer apply, lets try it out and see what breaks.