Don't log a warning for quarkus.version property #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven and Gradle properties are now pushed to config and if the property name starts with quarkus. and the property is not consumed, we get a warning. This is especially the case for quarkus.version and it should obviously be ignored. This is just a workaround, I think we need a more general solution.
|
@geoand can you review this one? It's just a quick workaround for the release. |
|
Workaround looks good but I agree that we will need a better solution for the build properties in the future |
|
Yeah, I pinged @dmlloyd on Zulip about this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven and Gradle properties are now pushed to config and if the property
name starts with quarkus. and the property is not consumed, we get a
warning.
This is especially the case for quarkus.version and it should obviously
be ignored.
This is just a workaround, I think we need a more general solution.