Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup codestarter test #33181

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Cleanup codestarter test #33181

merged 1 commit into from
Oct 31, 2023

Conversation

turing85
Copy link
Contributor

@turing85 turing85 commented May 6, 2023

  • Remove unnecessary modifiers
  • Unify line-breaks
  • Unify indentation

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label May 6, 2023
@iocanel iocanel self-requested a review May 7, 2023 10:13
iocanel
iocanel approved these changes May 7, 2023
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quarkus-bot

This comment has been minimized.

Sign in to view
@turing85
Copy link
Contributor Author

turing85 commented May 7, 2023

uhm... I am a little bit at a loss here. Tests fail with

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): GrpcCodestartTest/testContent/src_test_java_ilove_quark_us_HelloGrpcServiceTest.java]

Is this ignorable? If not: how to fix this?

@ia3andy
Copy link
Contributor

ia3andy commented May 8, 2023

@turing85 you need to either:

  • Fix the snapshots manually
  • Run the test with -Dsnap to update them (as explained in the log)

The snapshots are here to make sure the result of generating app with your changes in the templates is as expected

@gsmet gsmet force-pushed the feature/cleanup-codestarter-tests branch from 8b0cd78 to e973da8 Compare May 9, 2023 08:55
@gsmet
Copy link
Member

gsmet commented May 9, 2023

I pushed an update to synchronize the snapshots.

@turing85
Copy link
Contributor Author

turing85 commented May 9, 2023

I pushed an update to synchronize the snapshots.

Thanks!

@quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet previously requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about how two files are indented. Could you have a look?

...odestarts/reactive-routes-codestart/java/src/test/java/org/acme/MyDeclarativeRoutesTest.java Outdated Show resolved Hide resolved
...iveRoutesCodestartTest/testContent/src_test_java_ilove_quark_us_MyDeclarativeRoutesTest.java Outdated Show resolved Hide resolved
@turing85 turing85 force-pushed the feature/cleanup-codestarter-tests branch from e973da8 to c2889e8 Compare June 14, 2023 18:39
@turing85 turing85 requested a review from gsmet June 14, 2023 18:43
@turing85
Copy link
Contributor Author

I'm not sure about how two files are indented. Could you have a look?

The tabs were there already. I replaced them. I also rebased onto the current main. @gsmet care to re-evalute the PR now?

By-the-by: I did a global search on tabs in *.java files. Let's say there were enough hits that intelliJ refused to replace them all in one go. Should we create an issue to replace all those tabs?

@turing85 turing85 force-pushed the feature/cleanup-codestarter-tests branch from c2889e8 to b4e8f36 Compare June 14, 2023 19:08
@turing85
Copy link
Contributor Author

so... we wanna proceed with this PR or nah?

@turing85 turing85 force-pushed the feature/cleanup-codestarter-tests branch from 93b437e to 4d6f278 Compare October 27, 2023 15:33
@turing85
Cleanup codestarter tests
9d7b1b8 
- Remove unnecessary modifiers
- Unify line-breaks
- Unify indentation
@turing85 turing85 force-pushed the feature/cleanup-codestarter-tests branch from 4d6f278 to 9d7b1b8 Compare October 27, 2023 17:02
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 27, 2023

Failing Jobs - Building 9d7b1b8

Status Name Step Failures Logs Raw logs Build scan
✖ Native Tests - Windows - RESTEasy Jackson Setup GraalVM ⚠️ Check → Logs Raw logs

ia3andy
ia3andy approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ia3andy ia3andy merged commit e6423a4 into quarkusio:main Oct 31, 2023
49 of 50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 31, 2023
@ia3andy ia3andy mentioned this pull request Nov 2, 2023
Merged
40 tasks
@turing85 turing85 deleted the feature/cleanup-codestarter-tests branch March 6, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

@iocanel iocanel iocanel approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@turing85 @ia3andy @gsmet @iocanel