Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that ObjectMapperCustomizer impls are used in runtime init #33189

Merged
merged 1 commit into from
May 10, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented May 8, 2023

Fixes: #32969

Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me as long as the new test works.
I have only one question, but this is for my curiosity only :)

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor Author

geoand commented May 8, 2023

The failure is related and I'm looking into it.

@geoand geoand force-pushed the #32969 branch 2 times, most recently from 39d99a0 to 80eab58 Compare May 8, 2023 09:29
@geoand
Copy link
Contributor Author

geoand commented May 8, 2023

Should be good now

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented May 10, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 1090afd into quarkusio:main May 10, 2023
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels May 10, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 10, 2023
@geoand geoand deleted the #32969 branch May 11, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants