Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Vert.x 4.4.5 and Netty 4.1.97 #35700

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Update to Vert.x 4.4.5 and Netty 4.1.97 #35700

merged 1 commit into from
Sep 5, 2023
+40 −13

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Sep 4, 2023 •
edited
Loading

Also bump Quarkus HTTP to 5.0.3.Final to handle a breaking change in the Vert.x API.

Fix #35180
Fix #34719
Fix #35278

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/vertx labels Sep 4, 2023
@cescoffier
Copy link
Member Author

@ppalaga That's the PR related to the Vert.x update that should be backported.

@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor

geoand commented Sep 4, 2023

The test failures do seem related to the change.

@cescoffier
Copy link
Member Author

Yeah, I thing they are due to the getHost that changed.

@cescoffier
Update to Vert.x 4.4.5 and Netty 4.1.97
d41c78b 
Also bump Quarkus HTTP to 5.0.3.Final to handle a breaking change in the Vert.x API.

Fix quarkusio#35180
Fix quarkusio#34719
Fix quarkusio#35278
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 4, 2023

Failing Jobs - Building d41c78b

Status Name Step Failures Logs Raw logs Build scan
✖ Maven Tests - JDK 11 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Failures

⚙️ Maven Tests - JDK 11 #

- Failing: integration-tests/devmode

📦 integration-tests/devmode

✖ io.quarkus.test.devui.DevConsoleOidcJsonRPCTest.testGetProperties - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

@cescoffier cescoffier merged commit f073ee6 into quarkusio:main Sep 5, 2023
50 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Sep 5, 2023
@naah69
Copy link

naah69 commented Sep 6, 2023

Yeah, I thing they are due to the getHost that changed.

Will this merge to 2.x?

We are using 2.x ,but we have the problem that is #34719 (comment)

@geoand
Copy link
Contributor

geoand commented Sep 6, 2023

That is highly unlikely to happen

@cescoffier
Copy link
Member Author

No we do not plan to backport this to the 2.x branch.

@cescoffier cescoffier deleted the vertx-4.4.5-slim branch September 12, 2023 14:47
This was referenced Sep 17, 2023
Closed
Closed
@ppalaga
Copy link
Contributor

ppalaga commented Sep 17, 2023

@cescoffier @gsmet could you please confirm that you still plan to backport this to 3.2?

@cescoffier
Copy link
Member Author

Yes, it is still the plan. We are waiting to get more feedback before doing it. The forwarded request changes may have unexpected consequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/resteasy-classic area/vertx kind/bugfix
Projects
None yet
Milestone
3.4.0.CR1
6 participants
@cescoffier @geoand @naah69 @ppalaga @aloubyansky @gsmet