-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate docker files command #36178
base: main
Are you sure you want to change the base?
Conversation
@ia3andy: This is a draft of what we discussed the other day. Any feedback / suggestion is more than welcome. |
cc @maxandersen |
@iocanel here are some suggestions:
To pass the data use this: QuarkusCodestartProjectInput.builder()
.putData(QuarkusDataKey.PROJECT_ARTIFACT_ID, artifactId)
.putData(QuarkusDataKey.JAVA_VERSION, javaVersion) |
Do we have to split them? Can't we just configure using the map of build strategies to ignore the files we don't really need? |
Oh, I missed that one, that would be very nice if we could actually have it! |
I am not sure I get what you mean. FYI, currently there is no way to control whether a file is generated or not, we could introduce it. |
What I had in mind is something like:
And use BTW, I am not sure I am able to see how I can grab the maven coordinates for the QuarkusProject, any hints? |
@@ -28,7 +28,6 @@ public void process(Path targetDirectory, String relativePath, List<TargetFile> | |||
throws IOException { | |||
checkNotEmptyCodestartFiles(codestartFiles); | |||
final Path targetPath = targetDirectory.resolve(relativePath); | |||
checkTargetDoesNotExist(targetPath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because, this throws an exception preventing the actual file replacement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be the case as the file shouldn't exist before this is called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and throwing an exception if file exists doesn't sound like replace to me.
What do I miss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look just bellow the replace is working by using the latest file in the List
9f5bd14
to
e25f650
Compare
No description provided.