Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransactionalUniAsserter never fails with Hibernate Reactive #36599

Merged
merged 4 commits into from
Nov 2, 2023
Merged

TransactionalUniAsserter never fails with Hibernate Reactive #36599

merged 4 commits into from
Nov 2, 2023

Commits on Nov 2, 2023

  1. [quarkusio#36582] Fix bug: TransactionalUniAsserter never fails 

    TransactionalUniAsserterTestMethodInvoker is a subclass of
RunOnVertxContextTestMethodInvoker.

The problem is that there were two separate pointers keeping
track of the asserter in the superclass and in the subclass.
This lead to only one pointer being initialized and, if the wrong
pointer was null-checked, the asserter was ignored causing the test
to never fail.

This commit fixes the issue by keeping only one reference to the
asserter in the superclass.
    @DavideD
    DavideD committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5ddc8e5 View commit details
    Browse the repository at this point in the history

  2. [quarkusio#36582] Minor clean up in TransactionalUniAsserterTest 

    Use method reference where possible
    @DavideD
    DavideD committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    b44a56c View commit details
    Browse the repository at this point in the history

  3. [quarkusio#36582] Minor clean up around lambdas

    @DavideD
    DavideD committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a29061e View commit details
    Browse the repository at this point in the history

  4. [quarkusio#36582] Add UnwrappableUniAsserter interface 

    The goal is to extract the `asUni()` method from `UniAsserter`
    @DavideD
    DavideD committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    c44eab7 View commit details
    Browse the repository at this point in the history