Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the correct port properties for HTTPS #38006

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Set the correct port properties for HTTPS #38006

merged 1 commit into from
Jan 4, 2024

Conversation

rob-spoor
Copy link
Contributor

Fixes #37944 while still keeping full backward compatibility for those that use the incorrect properties.

Copy link

quarkus-bot bot commented Jan 3, 2024

Failing Jobs - Building 5bd6a79

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can also consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 87 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.HibernateHotReloadTestCase.testImportSqlWithContinuousTesting line 87 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 3 State{lastRun=1, running=true, inProgress=false, run=1, passed=1, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.hibernate.orm.HibernateHotReloadTestCase.testImportSqlWithContinuousTesting(HibernateHotReloadTestCase.java:87)

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit 0ca283e into quarkusio:main Jan 4, 2024
50 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 4, 2024
@rob-spoor
Copy link
Contributor Author

You're welcome :)

@gsmet gsmet modified the milestones: 3.7 - main, 3.6.5 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PortSystemProperties sets wrong properties for HTTPS
3 participants