Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Liberica NIK GraalVM version parsing #38148

Merged
merged 1 commit into from Jan 11, 2024

Conversation

gastaldi
Copy link
Contributor

Building a Quarkus application/extension with Liberica NIK gives the following error:

[ERROR] Caused by: java.lang.IllegalArgumentException: Cannot parse version from output:
[ERROR] native-image 21.0.1 2023-10-17
[ERROR] GraalVM Runtime Environment Liberica-NIK-23.1.1-1 (build 21.0.1+12-LTS)
[ERROR] Substrate VM Liberica-NIK-23.1.1-1 (build 21.0.1+12-LTS, serial gc)
[ERROR] 	at io.quarkus.deployment.pkg.steps.GraalVM$Version.of(GraalVM.java:281)
[ERROR] 	at io.quarkus.deployment.pkg.steps.NativeImageBuildRunner.getGraalVMVersion(NativeImageBuildRunner.java:37)
[ERROR] 	... 10 more

This PR should fix this issue.

The BellSoft Liberia NIK provides support for AWT in macOS environments, avoiding the java.lang.UnsatisfiedLinkError: No awt in java.library.path (see oracle/graal#4124 (comment) for more details)

Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nitpick: Given the new methods are exact copies of the mandrel ones except for the "prefix", I would make them take the "prefix" as a parameter and avoid code duplication.

@gastaldi
Copy link
Contributor Author

Nitpick: Given the new methods are exact copies of the mandrel ones except for the "prefix", I would make them take the "prefix" as a parameter and avoid code duplication.

Yeah, that class needs a good refactoring, we can do that in a separate PR

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 11, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 11, 2024

Failing Jobs - Building bac4131

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 87 more

📦 extensions/hibernate-orm/deployment

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.2.3:test (default-test) on project quarkus-hibernate-orm-deployment:

Please refer to /home/runner/work/quarkus/quarkus/extensions/hibernate-orm/deployment/target/surefire-reports for the individual test results.
Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process

@gastaldi
Copy link
Contributor Author

Errors are unrelated to this change

@gastaldi gastaldi merged commit 99b9b57 into quarkusio:main Jan 11, 2024
49 of 50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 11, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 11, 2024
@gastaldi gastaldi deleted the liberica branch January 11, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants