Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC: consolidate handling of transitive interceptor bindings #38277

Merged

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Jan 18, 2024

Notably, this commit makes transitive interceptor bindings available at runtime from the InvocationContext.

Fixes #38264

@Ladicek Ladicek added area/arc Issue related to ARC (dependency injection) triage/backport-3.8 labels Jan 18, 2024
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know Jandex now has AnnotationInstanceEquivalenceProxy 👍

This comment has been minimized.

Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Ladislav!

Notably, this commit makes transitive interceptor bindings available
at runtime from the `InvocationContext`.
@Ladicek Ladicek force-pushed the arc-transitive-interceptor-bindings branch from 0e441cf to 140fdd8 Compare January 18, 2024 16:23
@Ladicek
Copy link
Contributor Author

Ladicek commented Jan 18, 2024

Rebased after #38282

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 18, 2024
Copy link

quarkus-bot bot commented Jan 18, 2024

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@manovotn manovotn merged commit 768d9c5 into quarkusio:main Jan 19, 2024
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 19, 2024
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 19, 2024
@Ladicek Ladicek deleted the arc-transitive-interceptor-bindings branch January 19, 2024 07:04
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.0 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/bugfix
Projects
None yet
4 participants