Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Client: add support for new configuration options #38611

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Feb 6, 2024

The Vert.x Redis Client recently gained 2 new configuration options, the preferred protocol version for protocol negotiation and a hash slot cache TTL. This commit exposes these config options through Quarkus configuration mechanism.

The Vert.x Redis Client recently gained 2 new configuration options,
the preferred protocol version for protocol negotiation and a hash
slot cache TTL. This commit exposes these config options through
Quarkus configuration mechanism.
@cescoffier
Copy link
Member

Awesome, thanks!

Copy link

quarkus-bot bot commented Feb 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit dfe6985.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

@gsmet gsmet merged commit 5bd7071 into quarkusio:main Feb 6, 2024
30 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 6, 2024
@Ladicek Ladicek deleted the redis-config-new-options branch February 6, 2024 16:51
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.2 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants