-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RESTEasy Classic default JAX-RS security to make endpoint detection more robust #38622
Refactor RESTEasy Classic default JAX-RS security to make endpoint detection more robust #38622
Conversation
This comment has been minimized.
This comment has been minimized.
...easy/runtime/src/main/java/io/quarkus/resteasy/runtime/StandardSecurityCheckInterceptor.java
Show resolved
Hide resolved
...ns/security/spi/src/main/java/io/quarkus/security/spi/AdditionalSecuredMethodsBuildItem.java
Outdated
Show resolved
Hide resolved
Michal, @michalvavrik Thanks, it does look like it simplifies things, but I'd like to question if it is necessary to do this security related refactoring for the legacy extension, where everything is settled now, and we recommend the Resteasy Reactive extension. The code is simpler but it is a new code and we already cover the deny all use case with your fixes, tests |
this extension is not deprecated, I'll treat it differently when the deprecation happens; right now, there is product level support and according to discussion on renaming of RESTEasy Reactive, this extension is one used by majority of Jakarta REST users
Maybe I didn't describe it correctly in the PR description - current detection of endpoints is far from perfect, I did my best, but I don't believe I covered every inheritance combination. There is theoretical chance I covered all of them, but I think that's what we had thought last time. This is hardening PR. |
284b4af
to
46b39c8
Compare
BTW I couldn't do this originally because of the order of 2 PRs, this needed to be based on the combination of previous RC fixes. |
Status for workflow
|
I'd like to wait till Monday, @stuartwdouglas - have a quick look please if you can, it looks good |
This solution replaces build time detection of endpoints which proved to be an issue in past. I think it's more secure as annotation inheritance discord between CDI and JAX-RS is really complex.