Fix AppCDS generation when using podman

[geoand]

We use the same trick as used in native-image
building

• Fixes: AppCDS containerized generation runs with UID 1000 which can clash with an existing user with UID 1000 on the host #38616

[zakkak]

LGTM, but this is the third place we use this, so perhaps it's worth extracting it in a method and reusing it.

• quarkus/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/UpxCompressionBuildStep.java

  Lines 128 to 136 in f75790f

  	String uid = getLinuxID("-ur");
  	String gid = getLinuxID("-gr");
  	if (uid != null && gid != null && !uid.isEmpty() && !gid.isEmpty()) {
  	Collections.addAll(commandLine, "--user", uid + ":" + gid);
  	if (containerRuntime.isPodman() && containerRuntime.isRootless()) {
  	// Needed to avoid AccessDeniedExceptions
  	commandLine.add("--userns=keep-id");
  	}
  	}

• quarkus/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildLocalContainerRunner.java

  Lines 25 to 37 in 0af4d6a

  	if (containerRuntime.isDocker() && containerRuntime.isRootless()) {
  	Collections.addAll(containerRuntimeArgs, "--user", String.valueOf(0));
  	} else {
  	String uid = getLinuxID("-ur");
  	String gid = getLinuxID("-gr");
  	if (uid != null && gid != null && !uid.isEmpty() && !gid.isEmpty()) {
  	Collections.addAll(containerRuntimeArgs, "--user", uid + ":" + gid);
  	if (containerRuntime.isPodman() && containerRuntime.isRootless()) {
  	// Needed to avoid AccessDeniedExceptions
  	containerRuntimeArgs.add("--userns=keep-id");
  	}
  	}
  	}

I am also wondering whether we would need to include the WSL work around as well:

            if (containerRuntime.isInWindowsWSL()) {
                containerRuntimeArgs.add("--interactive");
            }

[geoand]

LGTM, but this is the third place we use this, so perhaps it's worth extracting it in a method and reusing it.

Where would you put it?

[zakkak]

LGTM, but this is the third place we use this, so perhaps it's worth extracting it in a method and reusing it.

Where would you put it?

There is io.quarkus.deployment.pkg.steps.LinuxIDUtil, we could either rename and extend it or create a similar class in the same package. For the time being it looks like this is only used by build steps.

[geoand]

Seems like a reasonable follow-up task

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 692a640.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

• Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)