WebSockets Next: add basic Dev UI #39484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Mar 15, 2024
mkouba
commented
- list WebSocket endpoints with info about open connections
- resolves WebSockets Next: add basic Dev UI #39464
|
/cc @cescoffier (devui), @phillip-kruger (devui) |
This comment has been minimized.
This comment has been minimized.
- list WebSocket endpoints with info about open connections - resolves quarkusio#39464
This comment has been minimized.
This comment has been minimized.
|
Lgtm |
phillip-kruger
approved these changes
Mar 15, 2024
cescoffier
approved these changes
Mar 18, 2024
|
I've added a simple UI for test connections to send/receive text messages. |
This comment has been minimized.
This comment has been minimized.
|
Is the test failure related to this change? |
Nope. But I need to investigate this flaky test a bit more. I was never able to reproduce it locally :-(. |
- make it possible to open/close Dev UI connection - send/receive text messages
Status for workflow
|
cescoffier
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.