Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify REST Client multipart support #40051

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Clarify REST Client multipart support #40051

merged 2 commits into from
Apr 12, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 12, 2024 •
edited
Loading

Originally reported here

@geoand geoand requested a review from gsmet April 12, 2024 15:36
gsmet
gsmet reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few minor suggestions.

docs/src/main/asciidoc/rest-client.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/rest-client.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/rest-client.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/rest-client.adoc Outdated Show resolved Hide resolved
geoand and others added 2 commits April 12, 2024 18:42
@geoand
Add a note about FileUpload and FileDownload
7210f5d 
These types should not have been added to the common module,
they should have gone into the server part
@geoand @gsmet
Improve the documentation about sending multipart with the REST Client
35f322f 
Co-authored-by: Guillaume Smet <guillaume.smet@gmail.com>
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 12, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 35f322f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 12, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 12, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 35f322f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit b2a5ea4 into quarkusio:main Apr 12, 2024
46 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 12, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 12, 2024
@github-actions GitHub Actions
Copy link

🙈 The PR is closed and the preview is expired.

@geoand geoand deleted the client-multipart-doc branch April 15, 2024 06:52
@gsmet gsmet modified the milestones: 3.10.0.CR1, 3.9.4 Apr 17, 2024
@gsmet
Copy link
Member

gsmet commented May 15, 2024

OK, this one is doc only and a bit annoying to backport so I think we can probably live with it. Removing the backport label.

Complain loudly if you really want it in 3.8 :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
Quarkus Documentation
Status: Done
Milestone
3.9.4
Development

Successfully merging this pull request may close these issues.
2 participants
@geoand @gsmet