Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Using the rest client - Fix rest-client-jackson add extension name #40168

Conversation

viniciusvasti
Copy link
Contributor

As per the statement right before the described command, I think the extension being added should be "rest-client-jackson" instead of "rest-client-reactive-jackson"

image

@viniciusvasti viniciusvasti changed the title Fix rest-client-jackson add extension name DOC: Using the rest client - Fix rest-client-jackson add extension name Apr 19, 2024
@viniciusvasti viniciusvasti force-pushed the docs/ascii-guides-rest-client-add-ext-command branch from 7b03d20 to d442d86 Compare April 19, 2024 22:04

This comment has been minimized.

Copy link

github-actions bot commented Apr 19, 2024

🙈 The PR is closed and the preview is expired.

@viniciusvasti viniciusvasti force-pushed the docs/ascii-guides-rest-client-add-ext-command branch from d442d86 to b975c5c Compare April 22, 2024 13:03

This comment has been minimized.

As per the statement right before the described command, I think the extension being added should be "rest-client-jackson" instead of "rest-client-reactive-jackson"
@viniciusvasti viniciusvasti force-pushed the docs/ascii-guides-rest-client-add-ext-command branch from b975c5c to d80f220 Compare April 22, 2024 21:48
Copy link

quarkus-bot bot commented Apr 22, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit d80f220.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@gsmet gsmet merged commit ebd8f23 into quarkusio:main Apr 23, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 23, 2024
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.0 Apr 23, 2024
@gsmet gsmet modified the milestones: 3.10.0, 3.9.5 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants