Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update suggested command for busy port detection during the start #40175

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

juazugas
Copy link
Contributor

Change the suggested command for busy port detection with the utility to dump socket statistics.

The command netstat was deprecated in linux and it is being retired from the default installed networking tools. The suggested command to look for the busy port may not be installed by default on the latest linux distributions (as it happened to me).

Find more information on the new tools on the article :
https://www.redhat.com/sysadmin/deprecated-linux-command-replacements

or the replacement announcement :
https://lists.debian.org/debian-devel/2009/03/msg00780.html

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to open a PR.
I think we should keep the reference to netstat though as macOS doesn't have ss (and I'm not sure the BSD have it).

Can you adjust and squash? Thanks!

@juazugas juazugas force-pushed the busy-port-detection-command branch from 1b572ba to a28c2aa Compare April 22, 2024 16:05
@quarkus-bot

This comment has been minimized.

@gsmet gsmet force-pushed the busy-port-detection-command branch from a28c2aa to e9ebdc7 Compare April 23, 2024 08:28
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I force pushed a small update to fix the formatting issue.

@quarkus-bot

This comment has been minimized.

Change deprecated busy port detection command with the utility
to dump socket statistics.
@gsmet gsmet force-pushed the busy-port-detection-command branch from e9ebdc7 to b0eacd4 Compare April 26, 2024 15:10
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 26, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b0eacd4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.OpenTelemetrySpanSecurityEventsTest.testSecurityEventTypes - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:351)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:344)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:827)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:817)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

@gsmet gsmet merged commit 01c11a0 into quarkusio:main Apr 30, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 30, 2024
@gsmet
Copy link
Member

gsmet commented Apr 30, 2024

Thanks for providing a PR!

@juazugas
Copy link
Contributor Author

juazugas commented May 1, 2024

Thanks @gsmet for your support and taking care of the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants