-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Panache bytecode enhancers to benefit from class transformers caches #40192
Conversation
.../main/java/io/quarkus/panache/common/deployment/PanacheHibernateCommonResourceProcessor.java
Outdated
Show resolved
Hide resolved
eb73ea1
to
1cefb15
Compare
.../main/java/io/quarkus/panache/common/deployment/PanacheHibernateCommonResourceProcessor.java
Outdated
Show resolved
Hide resolved
1cefb15
to
c73fc8c
Compare
"Undrafted" and rebased, let's have CI opinions as well. I described the rationale above and think it should be safe after having convinced myself while writing the rationale :) but let's have @FroMage review it please. |
This comment has been minimized.
This comment has been minimized.
.../main/java/io/quarkus/panache/common/deployment/PanacheHibernateCommonResourceProcessor.java
Outdated
Show resolved
Hide resolved
c73fc8c
to
dc0c2b5
Compare
Updated & rebased:
|
Status for workflow
|
Amended the PR to not cache the client-side transformations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that seems safer, I suppose transforming the accessors is only local-class dependent.
Pushed a follow-up as #40629 |
See also: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Bytecode.20transformers.20caches.20for.20Hibernate.20entities