Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets Next: send ping message from the server automatically #40207

Merged
merged 1 commit into from
Apr 24, 2024
Merged

WebSockets Next: send ping message from the server automatically #40207

merged 1 commit into from
Apr 24, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 23, 2024

Also rename config and properties -> needs an update in the migration guide.

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
Copy link
Contributor Author

mkouba commented Apr 23, 2024 •
edited

Blocked by #40214.

cescoffier
cescoffier approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments - nothing major.

Wondering about websockets.next instead of websocket-next (much better in yaml)

...yment/src/test/java/io/quarkus/websockets/next/test/subprotocol/SubprotocolSelectedTest.java Outdated Show resolved Hide resolved
...t/server/runtime/src/main/java/io/quarkus/websockets/next/WebSocketsServerRuntimeConfig.java Show resolved Hide resolved
...server/runtime/src/main/java/io/quarkus/websockets/next/runtime/WebSocketConnectionImpl.java Outdated Show resolved Hide resolved
@mkouba
WebSockets Next: send ping message from the server automatically
8357938 
- an opt-in config property is used to set the interval
- resolves quarkusio#39862
- rename WebSocketsRuntimeConfig to WebSocketsServerRuntimeConfig
- change the prefix from "quarkus.websockets-next" to
"quarkus.websockets-next.server"
@mkouba mkouba requested review from cescoffier and gsmet April 24, 2024 07:21
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 24, 2024 •
edited by github-actions bot

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8357938.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

gsmet
gsmet approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @cescoffier I let you merge it if all good for you.

@cescoffier cescoffier merged commit 323774b into quarkusio:main Apr 24, 2024
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 24, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@gastaldi gastaldi Awaiting requested review from gastaldi

@cescoffier cescoffier Awaiting requested review from cescoffier

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
3.11.0.CR1
Development

Successfully merging this pull request may close these issues.

websocket-next extension should be able to automatically broadcast pings
3 participants
@mkouba @cescoffier @gsmet