Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether outputDirectory is the root of the file system before using its parent #40437

Merged

Conversation

aloubyansky
Copy link
Member

@phillip-kruger does it make sense to you?

It seems like this could happen in remote dev case.

Copy link

quarkus-bot bot commented May 3, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f327ea0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillip-kruger phillip-kruger merged commit 016bfb5 into quarkusio:main May 3, 2024
24 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 3, 2024
@vsevel
Copy link
Contributor

vsevel commented May 7, 2024

I am trying quarkus core main and now I have:

Caused by: java.nio.file.AccessDeniedException: /target
at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:90)
at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106)
at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
at java.base/sun.nio.fs.UnixFileSystemProvider.createDirectory(UnixFileSystemProvider.java:438)
at java.base/java.nio.file.Files.createDirectory(Files.java:699)
at java.base/java.nio.file.Files.createAndCheckIsDirectory(Files.java:807)
at java.base/java.nio.file.Files.createDirectories(Files.java:793)
at io.quarkus.smallrye.openapi.deployment.SmallRyeOpenApiProcessor.storeGeneratedSchema(SmallRyeOpenApiProcessor.java:950)

I added back this to go further:

quarkus:
  smallrye-openapi:
    store-schema-directory: /tmp

@vsevel
Copy link
Contributor

vsevel commented May 7, 2024

can't reproduce it anymore... we are good (until it comes back)

@vsevel
Copy link
Contributor

vsevel commented May 7, 2024

I take that back: #40501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants