Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ! to fix code example #40476

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

maxandersen
Copy link
Member

@maxandersen maxandersen commented May 6, 2024

fixes #40195

Copy link

quarkus-bot bot commented May 6, 2024

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@maxandersen maxandersen changed the title add missing ! to fix #40195 Add missing ! to fix code example May 6, 2024
Copy link

quarkus-bot bot commented May 6, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c89c096.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented May 6, 2024

🙈 The PR is closed and the preview is expired.

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gastaldi gastaldi merged commit 81accf2 into quarkusio:main May 6, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 6, 2024
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

ServerRequestFilter Example if-else bug
3 participants